lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Jun 2011 23:58:50 -0400 (EDT) From: David Miller <davem@...emloft.net> To: bhutchings@...arflare.com Cc: shemminger@...tta.com, gthelen@...gle.com, shemminger@...ux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] sky2: avoid using uninitialized variable From: Ben Hutchings <bhutchings@...arflare.com> Date: Fri, 17 Jun 2011 04:51:35 +0100 > On Thu, 2011-06-16 at 23:10 -0400, David Miller wrote: >> From: Stephen Hemminger <shemminger@...tta.com> >> Date: Tue, 14 Jun 2011 00:02:30 -0400 >> >> > In my experience if phy reads once successfully, it is going >> > to read every time. If there is a problem it only happens on >> > the first access (powered off, bad timing, etc). >> >> It also happens when the PHY can't get a response for a certain >> register, for whatever reason, before internal hw timeouts trigger. >> >> Please, check all MII accesses. That's what I do in every driver >> I've written. > > It doesn't help that the mii_if_info operations are defined to never > return errors. This doesn't prevent drivers from doing so internally, > but it does set a bad example. I totally agree. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists