linux-kernel - reorganized struct inode results in unaligned accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 19 Jun 2011 19:33:08 +0300 (EEST)
From:	Meelis Roos <mroos@...ux.ee>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	Linux Kernel list <linux-kernel@...r.kernel.org>,
	sparclinux@...r.kernel.org
Subject: reorganized struct inode results in unaligned accesses

A week ago I noticed that in 3.0.0-rc3, sparc64 machines log a lot of 
unaligned accesses in different vfs functions in dmesg. I reported but 
obviously not well enough. Today I had a look at it and found the 
reason.

Commit 13e12d14e2dccc7995b8f15a5678a338ab4e6a8c (vfs: reorganize 'struct 
inode' layout a bit) changes i_state to be unsigned int instead of 
unsigned long. This is the cause of unaligned accesses on sparc64 and 
maybe others. Changing it back to unsigned long fixes the warnings but I 
did not look at the layout of the resulting struct - might leave a hole 
there.

-- 
Meelis Roos (mroos@...ux.ee)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/