linux-kernel - Re: [PATCH] security: inode: fixed coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Jun 2011 10:37:30 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Chris Forbes <chrisf@....co.nz>
cc:	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] security: inode: fixed coding style issue

On Fri, 17 Jun 2011, Chris Forbes wrote:

> --- a/security/inode.c
> +++ b/security/inode.c
> @@ -75,7 +75,8 @@ static struct inode *get_inode(struct super_block *sb, int mode, dev_t dev)
>  			inode->i_op = &simple_dir_inode_operations;
>  			inode->i_fop = &simple_dir_operations;
>  
> -			/* directory inodes start off with i_nlink == 2 (for "." entry) */
> +			/* directory inodes start off with i_nlink == 2
> +			 * (for "." entry) */

This is not correct for multi-line comments.

> -	static struct tree_descr files[] = {{""}};
> +	static struct tree_descr files[] = { {""} };

Why ?



-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/