linux-kernel - RE: [PATCH v2 1/4] Exynos4 NURI: configure regulators and PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Jun 2011 18:17:18 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Tushar Behera' <tushar.behera@...aro.org>, myungjoo.ham@...il.com
Cc:	'MyungJoo Ham' <myungjoo.ham@...sung.com>,
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	'Russell King' <linux@....linux.org.uk>,
	'Kyungmin Park' <kyungmin.park@...sung.com>,
	'Mark Brown' <broonie@...nsource.wolfsonmicro.com>,
	dg77.kim@...sung.com
Subject: RE: [PATCH v2 1/4] Exynos4 NURI: configure regulators and PMIC

Tushar Behera wrote:
> 
> On Wednesday 22 June 2011 08:01 AM, MyungJoo Ham wrote:
> > On Tue, Jun 21, 2011 at 2:33 PM, Tushar Behera<tushar.behera@...aro.org>
> wrote:
> >> On Tuesday 21 June 2011 07:37 AM, MyungJoo Ham wrote:
> >>>
> >>> Signed-off-by: MyungJoo Ham<myungjoo.ham@...sung.com>
> >>> Signed-off-by: Kyungmin Park<kyungmin.park@...sung.com>
> >>>
> >>> --
> >>> Changes from v1. Thanks so much for your valuable comments, Mark.
> >>> - Removed unnecessary initialization data
> >>> - Add __initdata where necessary
> >>> - Corrected a regulator name for ADC
> >>> ---
> >>>   arch/arm/mach-exynos4/mach-nuri.c |  622
> >>> ++++++++++++++++++++++++++++++++++++-
> >>>   1 files changed, 621 insertions(+), 1 deletions(-)
> >>>
> >> Will it be possible to move PMIC specific defines to a common file and make
> >> appropriate calls in the board-specific file?
> >>
> >> In that way, we can re-use this PMIC code on some other boards (e.g.
> >> Insignal low-cost board Origen featuring Exynos4210 also features MAX8997).
> >>
> >
> > Yes, we have tried creating PMIC defines at a seperated file in our
> > local repositories (still doing so in those repositories).
> > However, that ended up creating multiple PMIC defines (one PMIC define
> > file for each board); the connections between LDO# and devices are
> > different.
> >
> In that case, we can first post the Origen board support and PMIC code
> on the ML, then we would see if we can consolidate.
> 
> That looks more logical as per Mark's suggestion also.
> >>

Hi Tushar,

When you need to add similar or same functionality on your board, you can/should move it in common part.
Maybe 'should'...basically, nobody will apply same function into both place...

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/