linux-kernel - Re: [PATCH 16/37] Remove unneeded version.h includes (and add where needed) for drivers/usb/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jun 2011 11:20:37 +0300
From:	Felipe Balbi <balbi@...com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	LKML <linux-kernel@...r.kernel.org>, trivial@...nel.org,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Matthew Dharm <mdharm-usb@...-eyed-alien.net>,
	linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH 16/37] Remove unneeded version.h includes (and add where
 needed) for drivers/usb/

Hi,

On Fri, Jun 24, 2011 at 12:31:43AM +0200, Jesper Juhl wrote:
> It was pointed out by 'make versioncheck' that linux/version.h was not
> always being included where needed and sometimes included needlessly
> in drivers/usb/.
> This patch fixes up the includes.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>

Laurent, I guess Jesper needs your Ack for the uvc part. It looks good
to me, but I'll leave it to you.

> ---
>  drivers/usb/gadget/uvc.h         |    1 +
>  drivers/usb/gadget/uvc_v4l2.c    |    1 -
>  drivers/usb/storage/realtek_cr.c |    1 -
>  3 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/uvc.h b/drivers/usb/gadget/uvc.h
> index 5b79194..81971fb 100644
> --- a/drivers/usb/gadget/uvc.h
> +++ b/drivers/usb/gadget/uvc.h
> @@ -56,6 +56,7 @@ struct uvc_event
>  #include <linux/usb.h>	/* For usb_endpoint_* */
>  #include <linux/usb/gadget.h>
>  #include <linux/videodev2.h>
> +#include <linux/version.h>
>  #include <media/v4l2-fh.h>
>  
>  #include "uvc_queue.h"
> diff --git a/drivers/usb/gadget/uvc_v4l2.c b/drivers/usb/gadget/uvc_v4l2.c
> index 5e807f0..a715805 100644
> --- a/drivers/usb/gadget/uvc_v4l2.c
> +++ b/drivers/usb/gadget/uvc_v4l2.c
> @@ -16,7 +16,6 @@
>  #include <linux/errno.h>
>  #include <linux/list.h>
>  #include <linux/mutex.h>
> -#include <linux/version.h>
>  #include <linux/videodev2.h>
>  #include <linux/vmalloc.h>
>  #include <linux/wait.h>
> diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
> index d509a4a..fe21104 100644
> --- a/drivers/usb/storage/realtek_cr.c
> +++ b/drivers/usb/storage/realtek_cr.c
> @@ -26,7 +26,6 @@
>  #include <linux/sched.h>
>  #include <linux/workqueue.h>
>  #include <linux/kernel.h>
> -#include <linux/version.h>
>  
>  #include <scsi/scsi.h>
>  #include <scsi/scsi_cmnd.h>
> -- 
> 1.7.5.2
> 
> 
> -- 
> Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
> Don't top-post http://www.catb.org/jargon/html/T/top-post.html
> Plain text mails only, please.
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)