linux-kernel - Re: [PATCH 08/11] dynamic_debug: return int from ddebug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Jun 2011 12:24:34 -0600
From:	Jim Cromie <jim.cromie@...il.com>
To:	Bart Van Assche <bvanassche@....org>
Cc:	Jason Baron <jbaron@...hat.com>, linux-kernel@...r.kernel.org,
	gnb@...h.org, gregkh@...e.de
Subject: Re: [PATCH 08/11] dynamic_debug: return int from ddebug_change

On Tue, Jun 28, 2011 at 11:48 AM, Bart Van Assche <bvanassche@....org> wrote:
> On Tue, Jun 28, 2011 at 4:54 PM, Jason Baron <jbaron@...hat.com> wrote:
>> On Tue, Jun 28, 2011 at 12:24:56PM +0200, Bart Van Assche wrote:
>> > On Tue, Jun 28, 2011 at 9:09 AM, Jim Cromie <jim.cromie@...il.com> wrote:
>> > > @@ -425,6 +424,7 @@ static int ddebug_exec_query(char *query_string)
>> > >  #define MAXWORDS 9
>> > >        int nwords;
>> > >        char *words[MAXWORDS];
>> > > +       int nfound;
>> > >
>> > >        nwords = ddebug_tokenize(query_string, words, MAXWORDS);
>> > >        if (nwords <= 0)
>> > > @@ -435,7 +435,8 @@ static int ddebug_exec_query(char *query_string)
>> > >                return -EINVAL;
>> > >
>> > >        /* actually go and implement the change */
>> > > -       ddebug_change(&query, flags, mask);
>> > > +       nfound = ddebug_change(&query, flags, mask);
>> > > +
>> > >        return 0;
>> >
>> > Do these changes actually do anything, or did I miss something ?
>>
>> its used in a subsequent patch to decide whether or not to call
>> add_to_pending.
>
> As far as I can see your comment applies to the function
> ddebug_change() while my comment applies to the function
> ddebug_exec_query(). If you have a close look at the above changes you
> will see that these do nothing more than adding a dead assignment.
>
> Bart.
>

its dead in 8/11, but used in 9/11

 	nfound = ddebug_change(&query, flags, mask);

+	pr_info("nfound %d on %s\n", nfound, show_ddebug_query(&query));
+	if (!nfound)
+		ddebug_add_to_pending(&query, flags, mask);
+
 	return 0;

I can merge 8 & 9 if it matters,
but ISTM that the important part is that the patchset is bisectable.

- Things compile at each patch (with a couple warnings,
including unescape, which I fat-fingered and will fix)
$ for i in `seq 1 10`; do (cd - && git checkout HEAD~1 && git status);
make; done

- and functionality doesnt regress
AFAIK - I may have botched something while rebasing bits and pieces.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/