linux-kernel - Re: [PATCH v4] futex: Fix regression with read only mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Jun 2011 01:38:41 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Shawn Bohrer <sbohrer@...advisors.com>
cc:	Darren Hart <dvhart@...ux.intel.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	peterz@...radead.org, eric.dumazet@...il.com,
	david@...advisors.com, linux-kernel@...r.kernel.org,
	zvonler@...advisors.com, hughd@...gle.com, mingo@...e.hu
Subject: Re: [PATCH v4] futex: Fix regression with read only mappings

On Wed, 29 Jun 2011, Shawn Bohrer wrote:
> 
> While fixing the regression this patch opens up a possible bad
> scenarios as identified by KOSAKI Motohiro:
> 
> This patch also allows FUTEX_WAIT on RO private mappings which have
> the following corner case.

These two sentences make no sense at all. We really need a very
accurate description of this change. That code is subtle and we really
want to have a very clear and understandable changelog.

Your changelog fails the basic test by mentioning "corner case" simply
because the whole futex code consists only of corner cases.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/