linux-kernel - Re: [PATCH 3/3] Staging: comedi: fix warning: line over 80 characters issue in usbduxfast.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Jul 2011 11:43:06 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Ravishankar <ravishankarkm32@...il.com>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Ravishankar <ravi.shankar@...enturtles.in>
Subject: Re: [PATCH 3/3] Staging: comedi: fix warning: line over 80
 characters issue in usbduxfast.c

On Wed, Jul 06, 2011 at 01:56:50PM +0530, Ravishankar wrote:
> -	ret = request_firmware_nowait(THIS_MODULE,
> -				      FW_ACTION_HOTPLUG,
> -				      "usbduxfast_firmware.bin",
> -				      &udev->dev,
> -				      GFP_KERNEL,
> -				      usbduxfastsub + index,
> -				      usbduxfast_firmware_request_complete_handler);
> +	ret =
> +	request_firmware_nowait(THIS_MODULE,
> +				FW_ACTION_HOTPLUG,
> +				"usbduxfast_firmware.bin",
> +				&udev->dev,
> +				GFP_KERNEL,
> +				usbduxfastsub + index,
> +				usbduxfast_firmware_request_complete_handler);
> +

No.  Don't do this.  The "usbduxfast_firmware_request_complete_handler"
variable name is too long.  Rename it something shorter.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/