linux-kernel - Re: [PATCH 3/3] x86: ret_from_fork: use symbolic contants for bits in EFLAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jul 2011 12:36:25 +0300
From:	Pekka Enberg <penberg@...nel.org>
To:	Ian Campbell <ian.campbell@...rix.com>
Cc:	Cyrill Gorcunov <gorcunov@...il.com>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Brian Gerst <brgerst@...il.com>,
	Jan Beulich <JBeulich@...ell.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Frederic Weisbecker <fweisbec@...il.com>, x86@...nel.org
Subject: Re: [PATCH 3/3] x86: ret_from_fork: use symbolic contants for bits in EFLAGS

On Tue, Jul 5, 2011 at 4:00 PM, Ian Campbell <ian.campbell@...rix.com> wrote:
> Signed-off-by: Ian Campbell <ian.campbell@...rix.com>
> Cc: x86@...nel.org
> ---
>  arch/x86/kernel/entry_32.S |    2 +-
>  arch/x86/kernel/entry_64.S |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
> index 5c1a9197..f032530 100644
> --- a/arch/x86/kernel/entry_32.S
> +++ b/arch/x86/kernel/entry_32.S
> @@ -303,7 +303,7 @@ ENTRY(ret_from_fork)
>        call schedule_tail
>        GET_THREAD_INFO(%ebp)
>        popl_cfi %eax
> -       pushl_cfi $0x0202               # Reset kernel eflags
> +       pushl_cfi $(X86_EFLAGS_IF|0x2)  # Reset kernel eflags
>        popfl_cfi
>        jmp syscall_exit
>        CFI_ENDPROC
> diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
> index 9c28bd5..4c76abf 100644
> --- a/arch/x86/kernel/entry_64.S
> +++ b/arch/x86/kernel/entry_64.S
> @@ -399,7 +399,7 @@ ENTRY(ret_from_fork)
>
>        call schedule_tail                      # rdi: 'prev' task parameter
>
> -       pushq_cfi $0x0202
> +       pushq_cfi $(X86_EFLAGS_IF|0x2)
>        popfq_cfi                               # reset kernel eflags
>
>        GET_THREAD_INFO(%rcx)

Reviewed-by: Pekka Enberg <penberg@...nel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/