linux-kernel - Re: [PATCH 1/10 v2] Generic Watchdog Timer Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Jul 2011 21:30:48 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Wim Van Sebroeck <wim@...ana.be>
Cc:	Arnd Bergmann <arnd@...db.de>, LKML <linux-kernel@...r.kernel.org>,
	Linux Watchdog Mailing List <linux-watchdog@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH 1/10 v2] Generic Watchdog Timer Driver

On Wed, Jul 06, 2011 at 09:17:10PM +0200, Wim Van Sebroeck wrote:
> Hi Arnd,
> 
> > > +EXPORT_SYMBOL(watchdog_register_device);
> > 
> > How about making this EXPORT_SYMBOL_GPL?
> 
> My opinion: the new framework has been created for 2 reasons:
> 1) consolidation of the code that is being repeated in each driver
> 2) to make it possible to support more then one driver.
> If we want to support more then one driver, then the out-of-tree drivers
> would benefit from using the API. Even the non-GPL ones.

I strongly support Arnd. And if it helps getting out-of-tree drivers into the
tree, great! I'd think most watchdog-drivers are out-of-tree because of
laziness, not because of IP?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)