linux-kernel - Re: [PATCH 5/5] Staging: comedi: fix warning issue in unioxx5.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 7 Jul 2011 12:26:53 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Denis Kirjanov <kirjanov@...il.com>
Cc:	Ravishankar <ravishankarkm32@...il.com>,
	devel@...verdev.osuosl.org, gregkh@...e.de,
	linux-kernel@...r.kernel.org,
	Ravishankar <ravi.shankar@...enturtles.in>
Subject: Re: [PATCH 5/5] Staging: comedi: fix warning issue in unioxx5.c

On Thu, Jul 07, 2011 at 12:28:21PM +0400, Denis Kirjanov wrote:
> I wonder if this patch improves code readability
> 

I would like for the line width warning to be removed or that we
would allow longer lines.  I don't see a lot of value in it and it's
all to common to see code that does stuff like this:
							foo->
							  bar_fw_baz
							    [10 + 1
							       + 1]
							         = x;

But I've given up hoping that it will change.  People are going to
keep submitting these patches until we merge one of them so we might
as well merge the half way decent one that gets submitted.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/