[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 7 Jul 2011 12:53:15 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Andi Kleen <andi@...stfloor.org>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
akpm@...ux-foundation.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 1/3] x86, intel: Output microcode revision v3
* Andi Kleen <andi@...stfloor.org> wrote:
> From: Andi Kleen <ak@...ux.intel.com>
>
> I got a request to make it easier to determine the microcode update level
> on Intel CPUs. This patch adds a new "microcode" field to /proc/cpuinfo.
>
> The microcode level is also outputed on fatal machine checks together
> with the other CPUID model information.
>
> I removed the respective code from the microcode update driver, it
> just reads the field from cpu_data. Also when the microcode is updated
> it fills in the new values too.
>
> I had to add a memory barrier to native_cpuid to prevent it being
> optimized away when the result is not used.
>
> This turns out to clean up further code which already got this
> information manually. This is done in followon patches.
>
> v2: Lots of updates based on feedback.
> v3: Rename cpu_update to microcode. Misc changes from feedback.
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> ---
> arch/x86/include/asm/processor.h | 4 +++-
> arch/x86/kernel/cpu/intel.c | 13 +++++++++++++
> arch/x86/kernel/cpu/mcheck/mce.c | 9 +++++++--
> arch/x86/kernel/cpu/proc.c | 3 ++-
> arch/x86/kernel/microcode_intel.c | 14 +++++---------
> 5 files changed, 30 insertions(+), 13 deletions(-)
You have *still* ignored some of the review suggestions i gave you in
the previous thread, and you know that i won't apply your patches
without you addressing all feedback.
So why did you send this incomplete series?
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists