linux-kernel - Re: [PATCH 4/4] futex: warning corrections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jul 2011 15:39:04 +0300
From:	Vitaliy Ivanov <vitalivanov@...il.com>
To:	Darren Hart <dvhart@...ux.intel.com>, Jiri Kosina <jkosina@...e.cz>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>,
	"trivial@...nel.org" <trivial@...nel.org>
Subject: Re: [PATCH 4/4] futex: warning corrections

>> From 8eeaa5a97697bcc606aea23d32028aea7b271a96 Mon Sep 17 00:00:00 2001
>> From: Vitaliy Ivanov <vitalivanov@...il.com>
>> Date: Thu, 7 Jul 2011 00:05:05 +0300
>> Subject: [PATCH] futex: uninitialized warning corrections
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> kernel/futex.c: In function ‘fixup_pi_state_owner.clone.17’:
>> kernel/futex.c:1582:6: warning: ‘curval’ may be used uninitialized in this function
>> kernel/futex.c: In function ‘handle_futex_death’:
>> kernel/futex.c:2486:6: warning: ‘nval’ may be used uninitialized in this function
>> kernel/futex.c: In function ‘do_futex’:
>> kernel/futex.c:863:11: warning: ‘curval’ may be used uninitialized in this function
>> kernel/futex.c:828:6: note: ‘curval’ was declared here
>> kernel/futex.c:898:5: warning: ‘oldval’ may be used uninitialized in this function
>> kernel/futex.c:890:6: note: ‘oldval’ was declared here
>>
>> Signed-off-by: Vitaliy Ivanov <vitalivanov@...il.com>
>
> Please include a blurb in the commit message as to why you used
> uninitialized_var() rather than just assigning it. This will save people
> the time of wondering why, and me the time of nacking "it's simpler to
> just initialize to zero" patches :-)
>
> Acked-by: Darren Hart <dvhart@...ux.intel.com>

Darren,

Thanks for your comments. I think the description is pretty obvious
here as I don't think any of these variables are affected by cmpxchg.
There is simple assignment at the end. Seems like compiler simply
doesn't follow all the return cases.

Anyway, I'm going to resend patches to Jiri for his trivial-next tree.

Vitaliy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/