linux-kernel - Re: [PATCH] x86: Fix memory leak of init_vdso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 07 Jul 2011 11:33:34 -0700
From:	Andi Kleen <ak@...ux.intel.com>
To:	Michal Hocko <mhocko@...e.cz>
CC:	wzt <wzt.wzt@...il.com>, mingo@...hat.com,
	linux-kernel@...r.kernel.org, x86@...nel.org, tglx@...utronix.de,
	hpa@...or.com
Subject: Re: [PATCH] x86: Fix memory leak of init_vdso_vars()

On 7/7/2011 6:14 AM, Michal Hocko wrote:
> On Tue 05-07-11 14:21:48, wzt wrote:
>> Fix memory leak of init_vdso_vars().
>>
>> Signed-off-by: Zhitong Wang<zhitong.wangzt@...baba-inc.com>
> The patch looks correct but it could be cleaned up a bit IMO.
> See bellow.

When you run out of memory at early system boot (this is early
system boot only) the system is toast anyways. There's no way
to recover.

I would just add a few GFP_PANICs and then drop the error paths.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/