linux-kernel - Re: [PATCH] Staging: comedi: Fixing style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Jul 2011 11:26:34 -0700
From:	Greg KH <greg@...ah.com>
To:	markpearson_de@...oo.de
Cc:	abbotti@....co.uk, fmhess@...rs.sourceforge.net,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: Fixing style issues

On Sun, Jul 10, 2011 at 08:12:46PM +0200, markpearson_de@...oo.de wrote:
> From: Mark Pearson <markpearson_de@...oo.de>
> 
> comedi_fops.c : Warning that externs should be avoided in .c files.
>                 A forward function decleration was declared extern
>                 although it was only used internally. Changed
>                 decleration to static.
> comedi.h      : Fixed warning that storage class should be a the
>                 begining of declerations.
> 
> Lindent ran on both files.
> 
> Ignore previous patch - forgot to add signed off by.

Care to break this up into a set of "only do one thing per patch"
series?  That way it's reviewable.

Also, running Lindent is usually a very bad idea on files that have been
around for a while now.  It causes a lot of unneeded churn, please just
make the minor changes needed to be checkpatch.pl clean by hand.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/