linux-kernel - [PATCH] [RESENDING] dell-laptop - using buffer without mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 10 Jul 2011 15:46:51 -0300
From:	Jose Alonso <joalonsof@...il.com>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	Greg Dietsche <greg@...gd.org>, linux-kernel@...r.kernel.org
Subject: [PATCH] [RESENDING] dell-laptop - using buffer without mutex_lock

(resending patch with tabs and signed-off-by)

Using buffer->output[1] without mutex_lock()

Signed-off-by: Jose Alonso <joalonsof@...il.com>
version linux-3.0-rc6
--
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -560,11 +560,11 @@
 	else
 		dell_send_request(buffer, 0, 1);
 
+	ret = buffer->output[1];
+
 out:
 	release_buffer();
-	if (ret)
-		return ret;
-	return buffer->output[1];
+	return ret;
 }
 
 static const struct backlight_ops dell_ops = {


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/