linux-kernel - Re: [PATCH v3] fs, dlm: don't do pointless NULL check, use kzalloc and fix order of arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2011 11:02:33 -0400
From:	David Teigland <teigland@...hat.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org, cluster-devel@...hat.com,
	Christine Caulfield <ccaulfie@...hat.com>,
	"Dr. David Alan Gilbert" <linux@...blig.org>
Subject: Re: [PATCH v3] fs, dlm: don't do pointless NULL check, use kzalloc
 and fix order of arguments

On Sun, Jul 10, 2011 at 10:54:31PM +0200, Jesper Juhl wrote:
> In fs/dlm/lock.c in the dlm_scan_waiters() function there are 3 small
> issues:
> 
> 1) There's no need to test the return value of the allocation and do a
> memset if is succeedes. Just use kzalloc() to obtain zeroed memory.
> 
> 2) Since kfree() handles NULL pointers gracefully, the test of
> 'warned' against NULL before the kfree() after the loop is completely
> pointless. Remove it.
> 
> 3) The arguments to kmalloc() (now kzalloc()) were swapped. Thanks to
> Dr. David Alan Gilbert for pointing this out.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>

Thanks, I pushed this and a patch for the other swapped kmalloc to the
next branch.
Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/