linux-kernel - Re: [PATCH v2 0/6] ARM: make mach/hardware.h optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2011 10:31:58 -0500
From:	Rob Herring <robherring2@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Michal Simek <monstr@...str.eu>, nico@...xnic.net,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [PATCH v2 0/6] ARM: make mach/hardware.h optional

Arnd,

On 07/02/2011 04:24 AM, Arnd Bergmann wrote:
> On Wednesday 29 June 2011 18:46:53 Rob Herring wrote:
>>
>> From: Rob Herring <rob.herring@...xeda.com>
>>
>> Currently, all ARM platforms must have a mach/hardware.h include. This is
>> because it is ultimately included by linux/pci.h which is included in many
>> places even for !CONFIG_PCI.
>>
>> This could be fixed simply with an ifdef around the include of mach/hardware.h
>> in asm/pci.h. However, in the interest of fixing this for single kernel
>> binary builds, this series removes the include of mach/hardware.h outside of
>> mach-* and plat-*. What's used from hardware.h is a couple of PCI defines. 
>> Converting them to variables allows each platform to set the values as needed.
>>
>> This does not address the inclusion of mach/hardware.h under drivers/*. This
>> appears to be mostly older platforms. There could also be some indirect
>> inclusions from other mach/* headers.
>>
> 
> Hi Rob,
> 
> This is very good work, I really like it. I've mentioned one idea for
> an improvement in patch 5, which you can still integrate, but otherwise
> 
> Reviewed-by: Arnd Bergmann <arnd@...db.de>
> 
> for the whole series.
> 

I have an updated version ready to send out. Will you take this in your
tree including the 1st patch for pci flags functions? Also, what about
the powerpc conversion to generic pci flags?

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/