linux-kernel - Re: [PATCH 8/8] Staging: comedi: fix printk() issue in pcl818.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2011 11:06:44 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Ravishankar <ravishankarkm32@...il.com>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Ravishankar <ravi.shankar@...enturtles.in>
Subject: Re: [PATCH 8/8] Staging: comedi: fix printk() issue in pcl818.c

On Mon, Jul 11, 2011 at 12:49:14PM +0530, Ravishankar wrote:
> From: Ravishankar <ravi.shankar@...enturtles.in>
> 
> This is a patch to the pcl818.c file that fixes up a printk warning found by the checkpatch.pl tool
> 
> Signed-off-by: Ravishankar <ravishankarkm32@...il.com>
> ---
>  drivers/staging/comedi/drivers/pcl818.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
> index ae097b3..21f1cc9 100644
> --- a/drivers/staging/comedi/drivers/pcl818.c
> +++ b/drivers/staging/comedi/drivers/pcl818.c
> @@ -1447,7 +1447,7 @@ static int ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
>  	struct comedi_cmd *cmd = &s->async->cmd;
>  	int retval;
>  
> -	printk("pcl818_ai_cmd()\n");
> +	printk(KERN_INFO "pcl818_ai_cmd()\n");

KERN_INFO is too high a level here.  Ideally this would just be
removed.  Possibly made into a dev_dbg().

The same is true for some other printks in this series.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/