linux-kernel - Re: [PATCH v4] ARM: Use generic BUG() handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2011 17:01:22 -0700
From:	Simon Glass <sjg@...omium.org>
To:	Dave Martin <dave.martin@...aro.org>
Cc:	Russell King - ARM Linux <linux@....linux.org.uk>,
	Olof Johansson <olof@...om.net>,
	Stephen Boyd <sboyd@...eaurora.org>,
	anish singh <anish198519851985@...il.com>,
	lak <linux-arm-kernel@...ts.infradead.org>,
	Tony Lindgren <tony@...mide.com>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Joe Perches <joe@...ches.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Alexander Shishkin <virtuoso@...nd.org>,
	Phil Carmody <ext-phil.2.carmody@...ia.com>,
	Rabin Vincent <rabin@....in>,
	lk <linux-kernel@...r.kernel.org>,
	Omar Ramirez Luna <omar.ramirez@...com>
Subject: Re: [PATCH v4] ARM: Use generic BUG() handler

[Resent, without html, sorry]

Hi Russell & Dave,

On Thu, Jul 7, 2011 at 2:28 AM, Dave Martin <dave.martin@...aro.org> wrote:
> On Wed, Jul 06, 2011 at 09:06:07PM +0100, Russell King - ARM Linux wrote:
>>
>> Sorry, I've finally got back to looking at this.
>>
>> +               ".pushsection .rodata.str, \"aMS\", 1\n"        \
>>
>> According to my gas manual:
>>
>> | 7.88 `.pushsection NAME [, SUBSECTION] [, "FLAGS"[, @TYPE[,ARGUMENTS]]]'
>> | ...
[snip]
>> It appears that the TYPE argument is missing.  As the GAS manual says
>> its required, then I think it really ought to be there.  Any comment?
>
> I guess type should be %progbits.  That's what the compiler generates for
> the assembler input in similar situations.
>
> Interestingly, gas does not require this argument and seems to default to
> progbits anyway ... but it seems best to do what the manual says.
>

Thanks for this. I will update the patch and resend to the list.

Regards,
Simon

> Cheers
> ---Dave
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/