linux-kernel - Re: [PATCH]:drivers/md/raid10.c: r10buf_pool_alloc(): Set bi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Jul 2011 21:40:17 -0700
From:	Muthu Kumar <muthu.lkml@...il.com>
To:	NeilBrown <neilb@...e.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]:drivers/md/raid10.c: r10buf_pool_alloc(): Set bi_vcnt for
 the new bio.

Hi Neil,

>>
>> BTW, why are we not using bio_add_page() here to add the page to bio?
>
> How would that be useful?  We don't know what the underlying device is at
> this point, and the point of bio_add_page is to make sure the device can
> handle the extra page.
>
> We do call bio_add_page at the appropriate time in sync_request().

Yes. Thanks for the explanation.

Regards,
Muthu

>
> So - not applied.
>
> Thanks,
> NeilBrown
>
>
>>
>> Signed-off-by: Muthukumar R <muthur@...il.com>
>>
>> ------
>>  drivers/md/raid10.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>> ------
>> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
>> index 6e84668..8504c5b 100644
>> --- a/drivers/md/raid10.c
>> +++ b/drivers/md/raid10.c
>> @@ -129,6 +129,7 @@ static void * r10buf_pool_alloc(gfp_t gfp_flags, void *data)
>>
>>                         bio->bi_io_vec[i].bv_page = page;
>>                 }
>> +               bio->bi_vcnt = RESYNC_PAGES;
>>         }
>>
>>         return r10_bio;
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/