lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Jul 2011 13:48:05 +0900 From: Mark Brown <broonie@...nsource.wolfsonmicro.com> To: Grant Likely <grant.likely@...retlab.ca> Cc: Greg KH <greg@...ah.com>, Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>, Liam Girdwood <lrg@...com>, Samuel Oritz <sameo@...ux.intel.com>, Graeme Gregory <gg@...mlogic.co.uk>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/4] regulator: Convert tps65023 to use regmap API On Thu, Jul 14, 2011 at 08:53:28PM -0600, Grant Likely wrote: > On Sat, Jul 09, 2011 at 01:50:44PM +0900, Mark Brown wrote: > > - mutex_init(&tps->io_lock); > > + tps->regmap = regmap_init(&client->dev, &tps65023_regmap_config); > Yeah, if this usage is typical, the caller will always know exactly > what kind of regmap it needs to set up because it had an i2c_client or > an spi_device instance. I think it would be better to drop the > central registration of regmap bus types and use bus-specific init > variant. It just makes for one more bit of registration > infrastructure that needs to be setup before any drivers us it. Right, the driver is always going to know exactly what bus it registered on but for many drivers we don't really have any bus-specific code once we factor out the register I/O. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists