linux-kernel - RE: [PATCHv3] ARM: EXYNOS4: Support for generic I/O power domains on EXYNOS4210

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 16 Jul 2011 12:19:19 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Chanwoo Choi' <cw00.choi@...sung.com>
Cc:	"'Rafael J. Wysocki'" <rjw@...k.pl>,
	'Kyungmin Park' <kyungmin.park@...sung.com>,
	'MyungJoo Ham' <myungjoo.ham@...sung.com>,
	'Sylwester Nawrocki' <snjw23@...il.com>,
	linux-pm@...ts.linux-foundation.org,
	'linux-samsung-soc' <linux-samsung-soc@...r.kernel.org>,
	'linux-kernel' <linux-kernel@...r.kernel.org>
Subject: RE: [PATCHv3] ARM: EXYNOS4: Support for generic I/O power domains on
 EXYNOS4210

Chanwoo Choi wrote:
> 
> Kukjin Kim wrote:

(snip)

> >> @@ -183,6 +183,7 @@ config MACH_NURI
> >>  	select EXYNOS4_SETUP_SDHCI
> >>  	select EXYNOS4_SETUP_USB_PHY
> >>  	select SAMSUNG_DEV_PWM
> >> +	select PM_GENERIC_DOMAINS if PM
> >
> > Do you _really_ think this should be under MACH_NURI?
> >
> This patch apply the generic power-domain to NURI board.

I mean, the PM_GENERIC_DOMAINS feature depends on CPU not board even though this is for only NURI board.

(snip)

> >> diff --git a/arch/arm/mach-exynos4/include/mach/pm-exynos4210.h
> >> b/arch/arm/mach-exynos4/include/mach/pm-exynos4210.h
> >> new file mode 100644
> >> index 0000000..ab09034
> >> --- /dev/null
> >> +++ b/arch/arm/mach-exynos4/include/mach/pm-exynos4210.h
> >> @@ -0,0 +1,53 @@
> >> +/* linux/arch/arm/mach-exynos4/include/mach/pm-exynos4.h
> >
> > According to your file name, should be linux/arch/arm/mach-
> exynos4/include/mach/pm-exynos4210.h ?
> 
I said just typo...

+/* linux/arch/arm/mach-exynos4/include/mach/pm-exynos4210.h

> This patch support only power-domain of EXYNOS4210, so I named "pm-
> exynos4210.h"
> If EXYNOS4 series board will be released, I will modify include file name
> from "pm-exynos4210.h" to "pm-exynos4.h" to support all EXYNOS4 series.

No need it, it's different.

(snip)

> > Would be better if you could add some common function for pd_power_up and
> _down...
> 
> What do you mean about common function?
> 
I thought, pd_power_up and _down can be implemented in one function.

(snip)

> > I wonder why we need to add this for handling power domain not update current
> pd.
> 
See arch/arm/mach-exynos4/dev-pd.c

I mean, we _really_ need to keep duplication files for handling power domain?...

(snip)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/