linux-kernel - Re: [PATCH] tpm: Move tpm_tis_reenable_interrupts out of CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 17 Jul 2011 19:53:23 +0800
From:	Harry Wei <jiaweiwei.xiyou@...il.com>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	stefanb@...ux.vnet.ibm.com, sfr@...b.auug.org.au,
	srajiv@...ux.vnet.ibm.com, jmorris@...ei.org,
	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
	kongjianjun@...il.com, harryxiyou@...il.com
Subject: Re: [PATCH] tpm: Move tpm_tis_reenable_interrupts out of
 CONFIG_PNP block

On Sat, Jul 16, 2011 at 10:34:26PM -0700, Randy Dunlap wrote:
> New warning:
> drivers/char/tpm/tpm_tis.c:97: warning: 'is_itpm' defined but not used

From: Harry Wei <harryxiyou@...il.com>

This patch can fix above warning.

Reported-by: Randy Dunlap <rdunlap@...otime.net>
Signed-off-by: Harry Wei <harryxiyou@...il.com>
---
 drivers/char/tpm/tpm_tis.c |   20 --------------------
 1 files changed, 0 insertions(+), 20 deletions(-)

diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index dd21df5..5929bb2 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -79,26 +79,6 @@ enum tis_defaults {
 static LIST_HEAD(tis_chips);
 static DEFINE_SPINLOCK(tis_lock);
 
-#ifdef CONFIG_ACPI
-static int is_itpm(struct pnp_dev *dev)
-{
-	struct acpi_device *acpi = pnp_acpi_device(dev);
-	struct acpi_hardware_id *id;
-
-	list_for_each_entry(id, &acpi->pnp.ids, list) {
-		if (!strcmp("INTC0102", id->id))
-			return 1;
-	}
-
-	return 0;
-}
-#else
-static int is_itpm(struct pnp_dev *dev)
-{
-	return 0;
-}
-#endif
-
 static int check_locality(struct tpm_chip *chip, int l)
 {
 	if ((ioread8(chip->vendor.iobase + TPM_ACCESS(l)) &
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/