linux-kernel - Re: [PATCH] tpm: Fix compilation warning when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jul 2011 08:00:09 -0400
From:	Stefan Berger <stefanb@...ux.vnet.ibm.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
CC:	rdunlap@...otime.net, Rajiv Andrade <srajiv@...ux.vnet.ibm.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	James Morris <jmorris@...ei.org>, linux-next@...r.kernel.org
Subject: Re: [PATCH] tpm: Fix compilation warning when CONFIG_PNP is not defined

On 07/17/2011 07:16 PM, Stephen Rothwell wrote:
> Hi Stefan,
>
> On Sun, 17 Jul 2011 07:55:58 -0400 Stefan Berger<stefanb@...ux.vnet.ibm.com>  wrote:
>> The is_itpm() function is only accessed from a block surrounded by
>> #ifdef CONFIG_PNP. Therefore, also surround it with #ifdef CONFIG_PNP
>                  ^^^
>
>> --- linux-2.6.orig/drivers/char/tpm/tpm_tis.c
>> +++ linux-2.6/drivers/char/tpm/tpm_tis.c
>> @@ -80,7 +80,7 @@ enum tis_defaults {
>>   static LIST_HEAD(tis_chips);
>>   static DEFINE_SPINLOCK(tis_lock);
>>
>> -#ifdef CONFIG_ACPI
>> +#ifdef CONFIG_PNPN
>                   ^^^^
> Is this a typo?
>
Argh, yes.

    Stefan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/