linux-kernel - Re: [PATCH 30/30 v2] Staging: comedi: fix printk() issue in das16m1.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 Jul 2011 08:46:24 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	Ravishankar <ravishankarkm32@...il.com>,
	devel@...verdev.osuosl.org, gregkh@...e.de,
	linux-kernel@...r.kernel.org,
	Ravishankar <ravi.shankar@...enturtles.in>
Subject: Re: [PATCH 30/30 v2] Staging: comedi: fix printk() issue in
 das16m1.c

On Mon, 2011-07-18 at 11:43 +0200, Jesper Juhl wrote:
> On Mon, 18 Jul 2011, Ravishankar wrote:
> > -	printk(" io 0x%lx-0x%lx 0x%lx-0x%lx",
> > +	printk(KERN_INFO " requesing the I/O region from 0x%lx-0x%lx 0x%lx-0x%lx",
> Correct spelling is "requesting" and the "from" should either have a 
> matching "to" or just be dropped IMHO.
> Personally I'd just make it:
> " requesting I/O region 0x%lx-0x%lx 0x%lx-0x%lx"
[]
> I think the original text was better.

KERN_INFO is the wrong level.

Just log the errors at KERN_ERR/pr_err and make the rest
pr_debug or delete them.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/