lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Jul 2011 09:22:01 +0530 From: Ravishankar <ravishankarkm32@...il.com> To: gregkh@...e.de, wfp5p@...ginia.edu Cc: devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, Ravishankar <ravi.shankar@...enturtles.in>, Ravishankar <ravishankarkm32@...il.com> Subject: [PATCH 1/2 v2] Staging: comedi: fix printk() issue in adv_pci1710.c From: Ravishankar <ravi.shankar@...enturtles.in> This is a patch to the adv_pci1710.c file that fixes up a printk() warning found by the checkpatch.pl tool Signed-off-by: Ravishankar <ravishankarkm32@...il.com> --- KERN_INFO is replaced by KERN_ERR. drivers/staging/comedi/drivers/adv_pci1710.c | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/drivers/staging/comedi/drivers/adv_pci1710.c index fd71cc6..093b9e6 100644 --- a/drivers/staging/comedi/drivers/adv_pci1710.c +++ b/drivers/staging/comedi/drivers/adv_pci1710.c @@ -1396,14 +1396,14 @@ static int pci1710_attach(struct comedi_device *dev, int i; int board_index; - printk("comedi%d: adv_pci1710: ", dev->minor); + printk(KERN_INFO "comedi%d: adv_pci1710: ", dev->minor); opt_bus = it->options[0]; opt_slot = it->options[1]; ret = alloc_private(dev, sizeof(struct pci1710_private)); if (ret < 0) { - printk(" - Allocation failed!\n"); + printk(KERN_ERR " - Allocation failed!\n"); return -ENOMEM; } @@ -1451,10 +1451,10 @@ static int pci1710_attach(struct comedi_device *dev, if (!pcidev) { if (opt_bus || opt_slot) { - printk(" - Card at b:s %d:%d %s\n", + printk(KERN_ERR " - Card at b:s %d:%d %s\n", opt_bus, opt_slot, errstr); } else { - printk(" - Card %s\n", errstr); + printk(KERN_ERR " - Card %s\n", errstr); } return -EIO; } @@ -1465,7 +1465,7 @@ static int pci1710_attach(struct comedi_device *dev, irq = pcidev->irq; iobase = pci_resource_start(pcidev, 2); - printk(", b:s:f=%d:%d:%d, io=0x%4lx", pci_bus, pci_slot, pci_func, + printk(KERN_INFO ", b:s:f=%d:%d:%d, io=0x%4lx", pci_bus, pci_slot, + pci_func, iobase); dev->iobase = iobase; @@ -1487,7 +1487,7 @@ static int pci1710_attach(struct comedi_device *dev, ret = alloc_subdevices(dev, n_subdevices); if (ret < 0) { - printk(" - Allocation failed!\n"); + printk(KERN_ERR " - Allocation failed!\n"); return ret; } @@ -1499,14 +1499,14 @@ static int pci1710_attach(struct comedi_device *dev, IRQF_SHARED, "Advantech PCI-1710", dev)) { printk - (", unable to allocate IRQ %d, DISABLING IT", + (KERN_CONT ", unable to allocate IRQ %d, DISABLING IT", irq); irq = 0; /* Can't use IRQ */ } else { - printk(", irq=%u", irq); + printk(KERN_CONT ", irq=%u", irq); } } else { - printk(", IRQ disabled"); + printk(KERN_CONT ", IRQ disabled"); } } else { irq = 0; @@ -1514,7 +1514,7 @@ static int pci1710_attach(struct comedi_device *dev, dev->irq = irq; - printk(".\n"); + printk(KERN_CONT ".\n"); subdev = 0; -- 1.6.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists