linux-kernel - RE: [Query]: What should we do in txd->tx_submit() and device_issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Jul 2011 14:19:03 +0530
From:	"Koul, Vinod" <vinod.koul@...el.com>
To:	viresh kumar <viresh.kumar@...com>,
	"Williams, Dan J" <dan.j.williams@...el.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Shiraz HASHIM <shiraz.hashim@...com>,
	Armando VISCONTI <armando.visconti@...com>
Subject: RE: [Query]: What should we do in txd->tx_submit() and
 device_issue_pending()

(pls wrap your email to 80lines, I have reflowed below for readability) 
> Hi Dan/Vinod,
> 
> I have one query regarding implementation of few routines in DMA drivers.
> 
> What the exact purpose of txd->tx_submit() and device_issue_pending() routines?
> 
> Should tx_submit() always start physical transfer (Obviously, if channel is
> free)? Or should it just queue requests and then finally a call to
> device_issue_pending() must start physical transfers?
(reflowed your email for 80lines)
tx_submit is not supposed to start the transfer, it is supposed to add the 
descriptors in dma driver's queue. The issue_pending is supposed to actually 
start the transfer. The reasons were well articulated is discussion we had 
when we did the DMA documentation.
Pls see https://lkml.org/lkml/2011/5/24/530

~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/