| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Jul 2011 16:50:51 +0400 From: Vasiliy Kulikov <segoon@...nwall.com> To: Oleg Nesterov <oleg@...hat.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Balbir Singh <bsingharora@...il.com>, Jerome Marchand <jmarchan@...hat.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] taskstats: add_del_listener() should ignore !valid listener's On Wed, Jul 20, 2011 at 23:01 +0200, Oleg Nesterov wrote: > > it is unknown when it died. As the same pid > > can be reused by a new process BEFORE add_del_listener(), it is unknown > > whether ->pid points to the actual owner task. > > And? Why should we try to reuse the !valid entries? struct listener > is just the "addr" we should send the message to. If someone calls > add_listener() it should works regardless of dead entries with the > same ->pid. True. > > Rather than optimizing the wrong algorithm it's better to change the > > processes keeping way. > > Not sure I understand... This is not optimizing, the patch tries to > fix the unlikely (in fact mostly theoretical) and minor problem. Ah, I see the problem here. Yes, then it surely makes sense. Reviewed-by: Vasiliy Kulikov <segoon@...nwall.com> Thanks, -- Vasiliy Kulikov http://www.openwall.com - bringing security into open computing environments -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists