linux-kernel - Re: [PATCH 1/2] staging: vt6655: simplify MAC printing by using %pMF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Jul 2011 07:24:16 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: vt6655: simplify MAC printing by using
 %pMF

On Thu, 2011-07-21 at 15:42 +0300, Andy Shevchenko wrote:
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>  drivers/staging/vt6655/device_main.c |   10 +-----
>  drivers/staging/vt6655/dpc.c         |   30 ++++----------------
>  drivers/staging/vt6655/wmgr.c        |   49 +++++++---------------------------
[ patches like ]
> +	DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "Probe request rx:MAC addr:%pMF\n",
> +		sFrame.pHdr->sA3.abyAddr2);

Please use %pM here and in [2/2] as well.

%pMF should be used only for FDDI.

It looks as if this was someones idea to separate
the OUI out of the mac address.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/