linux-kernel - Re: [PATCH v5 1/1] input: add driver for Bosch Sensortec's BMA150 accelerometer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Jul 2011 11:45:21 +0200
From:	Eric Andersson <eric.andersson@...xphere.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	zhengguang.guo@...ch-sensortec.com, stefan.nilsson@...xphere.com,
	alan@...rguk.ukuu.org.uk,
	Albert Zhang <xu.zhang@...ch-sensortec.com>
Subject: Re: [PATCH v5 1/1] input: add driver for Bosch Sensortec's BMA150
 accelerometer

Hi Dmitry,

Thanks for reviewing!

> > +static int bma150_open(struct bma150_data *bma150)
> > +{
> > +#ifdef CONFIG_PM_RUNTIME
> > +	return pm_runtime_get_sync(&bma150->client->dev);
> > +#else
> > +	return bma150_set_mode(bma150->client, BMA150_MODE_NORMAL);
> 
> Hmm, this is kind of weird. I'd expect you want to try waking up the
> parent in both cases (if no runtime pm then call to pm_runtime_get_sync
> is basically a noop) and then wake up your device.

I am not sure what you mean? Are you suggesting something like:
	bma150_set_mode(bma150->client, BMA150_MODE_NORMAL);
	return pm_runtime_get_sync(&bma150->client->dev);

That would cause multiple bma150_set_mode() calls since
pm_runtime_get_sync() will trigger one if needed.

As for the rest of your comments I agree and will make sure to update
them for next version.

--
Best regards,
 Eric

 http://www.unixphere.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/