linux-kernel - Re: linux-next: Tree for July 20 (overlayfs)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 22 Jul 2011 13:38:59 +0200
From:	Sedat Dilek <sedat.dilek@...glemail.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Randy Dunlap <rdunlap@...otime.net>
Subject: Re: linux-next: Tree for July 20 (overlayfs)

On Fri, Jul 22, 2011 at 11:51 AM, Miklos Szeredi <miklos@...redi.hu> wrote:
[ ... ]
> And ->fsync is another one that will have an updated API.
>
> Miklos
>
> ---
>  fs/overlayfs/readdir.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> Index: linux-2.6/fs/overlayfs/readdir.c
> ===================================================================
> --- linux-2.6.orig/fs/overlayfs/readdir.c       2011-07-21 17:07:52.000000000 +0200
> +++ linux-2.6/fs/overlayfs/readdir.c    2011-07-21 17:10:20.000000000 +0200
> @@ -386,7 +386,8 @@ static loff_t ovl_dir_llseek(struct file
>        return res;
>  }
>
> -static int ovl_dir_fsync(struct file *file, int datasync)
> +static int ovl_dir_fsync(struct file *file, loff_t start, loff_t end,
> +                        int datasync)
>  {
>        struct ovl_dir_file *od = file->private_data;
>
> @@ -400,7 +401,7 @@ static int ovl_dir_fsync(struct file *fi
>                        return PTR_ERR(od->realfile);
>        }
>
> -       return vfs_fsync(od->realfile, datasync);
> +       return vfs_fsync_range(od->realfile, start, end, datasync);
>  }
>
>  static int ovl_dir_release(struct inode *inode, struct file *file)
>

OK, I see your patch is like mine due to changes in linux-next (here:
I checked with next-20110721):

commit cbc4facd43b3502f644d7f01a9a48f8bec5f3e57
"fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers"

Is it possible to have a clean...

1. OverlayFS v11 against Linux-3.0
2. OverlayFS v11 against vfs-2.6.git#for-next (see [2])

- Sedat -

[1] <http://git.us.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=commit;h=cbc4facd43b3502f644d7f01a9a48f8bec5f3e57>
[2]  <http://git.us.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=shortlog;h=refs/heads/for-next>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/