linux-kernel - Re: [PATCH] arm: omap: usb: clock enable typo fix in usbhs driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 22 Jul 2011 17:57:26 +0530
From:	"Munegowda, Keshava" <keshava_mgowda@...com>
To:	balbi@...com
Cc:	linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, gadiyar@...com,
	sameo@...ux.intel.com, parthab@...ia.ti.com, kishon@...com
Subject: Re: [PATCH] arm: omap: usb: clock enable typo fix in usbhs driver

On Fri, Jul 22, 2011 at 5:52 PM, Felipe Balbi <balbi@...com> wrote:
> Hi,
>
> On Tue, Jul 19, 2011 at 07:41:43PM +0530, Keshava Munegowda wrote:
>> From: Keshava Munegowda <Keshava_mgowda@...com>
>
> $SUBJECT is quite weird. First, this is not a patch on arch/arm/*omap*/
> so arm: omap: is already wrong. Also, "enable typo fix" is quite werid.
>
> Something like: "mfd: omap-usb-host: fix clock API usage on
> usbhs_disable()" would read better.
>
>> The usbhs_disable function was invoking clk_enable api
>> instead of clk_disable; The clk_disable is called to
>                        ^ this semicolon should be a period.
>
> ok, you're missing the actual problem here. How about you extend it to
> read as:
>
> usbhs_disable function was invoking clk_enable() instead of
> clk_disable(), thus only increasing the clock usage counter and
> preventing this particular clock from being ever turned off.
>
> Because of that, the power domain where the USB Host subsystem is
> located, would never reach lower power states.
>
>> disble the port clocks of usbhs
>    ^^ disable.
>
> --
> balbi

Thanks I will send the updated patch soon.

>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/