linux-kernel - Re: Linux 3.0 STILL dies on USB device hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Jul 2011 15:52:28 -0400
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	stern@...land.harvard.edu, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org, torvalds@...ux-foundation.org,
	stable@...nel.org, Dan Williams <dan.j.williams@...el.com>
Subject: Re: Linux 3.0 STILL dies on USB device hotplug - please merge fix
 ASAP

On Fri, 2011-07-22 at 19:02 +0200, Andi Kleen wrote:
> Hi,
> 
> 3.0 still oopses and dies immediately on USB device hot unplug.
> The same problem also triggered with SAS device according to Dan.
> 
> There was a lot of debugging on this a few weeks back and Alan Stern
> posted a SCSI layer patch that fixed the problem (for both USB
> and SAS):
> 
> http://68.183.106.108/lists/linux-usb/msg49001.html
> 
> But for some reason that patch didn't make it into 3.0 and 3.0 still
> happily oopses as the RC*s.
> 
> Can you please merge this patch ASAP?  This should also go to stable.
> 
> At least for me it makes pure 3.0 very risky to use, because these USB 
> hotunplug events are not uncommon and I end up with a dead machine.

Like I said at the time, the patch is wrong because of the relocation of
the queue teardown.  I posted a corrected version, but did anyone test?
Anyway, I merged it on the grounds that it worked for me, but if you
could confirm with linux-next, that would be great (I'll send the pull
request shortly, since it now needs to go via the merge window and I'm
currently in mid journey to Russia.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/