lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 22 Jul 2011 17:31:46 -0400
From:	Devin Heitmueller <dheitmueller@...nellabs.com>
To:	Ondrej Zary <linux@...nbow-software.org>
Cc:	Joerg Heckenbach <joerg@...kenbach-aw.de>,
	Dwaine Garden <dwainegarden@...ers.com>,
	linux-media@...r.kernel.org,
	Kernel development list <linux-kernel@...r.kernel.org>,
	Hans Verkuil <hverkuil@...all.nl>
Subject: Re: [PATCH] [resend] usbvision: disable scaling for Nogatech MicroCam

On Fri, Jul 22, 2011 at 5:22 PM, Ondrej Zary <linux@...nbow-software.org> wrote:
> Seems that this bug is widespread - the same problem appears also in guvcview
> and adobe flash. I think that the driver is broken too - it should return
> corrected resolution in TRY_FMT.

Well, if the driver does not return the resolution it is actually
capturing in, then that indeed is a driver bug.  That's a different
issue though than what your patch proposed.

You should make the TRY_FMT call specifying an invalid resolution and
see if it returns the real resolution the device will capture at.  If
it doesn't, then fix *that* bug.

The application needs to know the capturing resolution, so it's
possible that it does properly handle the driver passing back the real
resolution and the driver is at fault, in which case no change is
needed to the app at all.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ