linux-kernel - Re: [PATCH] xfs: Fix wrong return value of xfs_file_aio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 24 Jul 2011 07:57:52 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Markus Trippelsdorf <markus@...ppelsdorf.de>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Josef Bacik <josef@...hat.com>, linux-fsdevel@...r.kernel.org,
	viro@...iv.linux.org.uk, jack@...e.cz,
	linux-kernel@...r.kernel.org, Dave Chinner <david@...morbit.com>,
	xfs@....sgi.com
Subject: Re: [PATCH] xfs: Fix wrong return value of xfs_file_aio_write

On Sun, Jul 24, 2011 at 01:54:20PM +0200, Markus Trippelsdorf wrote:
> On 2011.07.24 at 07:16 -0400, Christoph Hellwig wrote:
> > On Sun, Jul 24, 2011 at 12:02:12AM +0200, Markus Trippelsdorf wrote:
> > > The following patch fixes the problem for me:
> > 
> > Good catch, can you send it with a proper signoff and description?
> 
> The fsync prototype change commit 02c24a82187d accidentally overwrote
> the ssize_t return value of xfs_file_aio_write with 0 for SYNC type
> writes. Fix this by checking if an error occured when calling
> xfs_file_fsync and only change the return value in this case.
> In addition xfs_file_fsync actually returns a normal negative error, so
> fix this, too.
> ---
>  fs/xfs/linux-2.6/xfs_file.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)

The Signed-off-by: line is still missing, and you normally shouldn't
quote the previous mail you reply to for patches.  Sorry for beeing
nit-picky, but see this as a training exercise :)

You can also add:

Reviewed-by: Christoph Hellwig <hch@....de>
Tested-by: Christoph Hellwig <hch@....de>

as I've run this through xfsqa (strictly speaking it's still running,
but it looks good so far)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/