linux-kernel - Re: [patch 1/2] fuse: delete dead .write_begin and .write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jul 2011 16:49:42 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Johannes Weiner <jweiner@...hat.com>
Cc:	Miklos Szeredi <miklos@...redi.hu>,
	fuse-devel@...ts.sourceforge.net, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 1/2] fuse: delete dead .write_begin and .write_end aops

On Mon, Jul 25, 2011 at 10:35:34PM +0200, Johannes Weiner wrote:
> Ever since 'ea9b990 fuse: implement perform_write', the .write_begin
> and .write_end aops have been dead code.
> 
> Their task - acquiring a page from the page cache, sending out a write
> request and releasing the page again - is now done batch-wise to
> maximize the number of pages send per userspace request.

The loop code still calls them uncondtionally.  This actually is a big
as write_begin and write_end require filesystems specific locking,
and might require code in the filesystem to e.g. update the ctime
properly.  I'll let Miklos chime in if leaving them in was intentional,
and if it was a comment is probably justified.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/