linux-kernel - Re: On migrate_disable() and latencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Jul 2011 10:30:53 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	paulmck@...ux.vnet.ibm.com
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-rt-users <linux-rt-users@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>, Carsten Emde <ce@...g.ch>,
	Clark Williams <williams@...hat.com>,
	Kumar Gala <galak@...e.crashing.org>,
	Ralf Baechle <ralf@...ux-mips.org>,
	rostedt <rostedt@...dmis.org>
Subject: Re: On migrate_disable() and latencies

On Fri, 2011-07-22 at 17:39 -0700, Paul E. McKenney wrote:
> > Therefore the worst case latency is in the order of
> > max-migrate-disable-period * nr-cpus.
> 
> OK, but wouldn't that be the latency as seen be the lowest-priority
> task?  

It would indeed, the utility loss is added to the preemption cost of the
lower priority tasks.

> Or are migrate-disable tasks given preferential treatment?
> If not, a prio-99 task would get the same latency either way, right?

Right.

> Migration-disable can magnify the latency seen by low-priority tasks, if
> I understand correctly.  If you disabled preemption, when a low-priority
> task became runnable, it would find an idle CPU.  But with migration
> disable, the lowest-priority task might enter a migration-disable region,
> then be preempted by a marginally higher-priority task that also enters
> a migration-diable region, and is also preempted, and so on.  The
> lowest-priority task cannot run on the current CPU because of all
> the higher-priority tasks, and cannot migrate due to being in a
> migration-disable section.

Exactly so.

> In other words, as is often the case, better worst-case service to
> the high-priority tasks can multiply the latency seen by the
> low-priority tasks.
> 
> So is the topic to quantify this?  

I suppose it is indeed. Even for the SoftRT case we need to make sure
the total utilization loss is indeed acceptable.

> If so, my take is that the latency
> to the highest-priority task decreases by an amount roughly equal to
> the duration of the longest preempt_disable() region that turned into a
> migration-disable region, while that to the lowest-priority task increases
> by N-1 times the CPU overhead of the longest migration-disable region,
> plus context switches.  (Yes, this is a very crude rule-of-thumb model.
> A real model would have much higher mathematics and might use a more
> detailed understanding of the workload.)
> 
> Or am I misunderstanding how all this works? 

No, I think you're gettin' it.

My main worry with all this is that we have these insane long !preempt
regions in mainline that are now !migrate regions, and thus per all the
above we could be looking at a substantial utilization loss.

Alternatively we could all be missing something far more horrid, but
that might just be my paranoia talking.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/