linux-kernel - Re: [PATCH v2] coccicheck: add parallel execution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Jul 2011 08:18:42 +0200
From:	Nicolas Palix <Nicolas.Palix@...ia.fr>
To:	Greg Dietsche <Gregory.Dietsche@....edu>
Cc:	joe@...ches.com, julia@...u.dk, Gilles.Muller@...6.fr,
	rdunlap@...otime.net, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, cocci@...u.dk, mmarek@...e.cz
Subject: Re: [PATCH v2] coccicheck: add parallel execution

On Wed, Jul 27, 2011 at 12:36 AM, Greg Dietsche
<Gregory.Dietsche@....edu> wrote:
> For example to process 6 SmPL patches at the same time:
>        make coccicheck PARALLEL=6
>
> Results are held in /tmp until the scripts finish. By doing this the
> script is able to collate the results from each SmPL patch instead of
> interleaving them in the output.
>
> Version 2: change pkill -P $$ to pkill -s 0
>
> Signed-off-by: Greg Dietsche <Gregory.Dietsche@....edu>
Acked-by: Nicolas Palix <npalix.work@...il.com>
> ---
>  scripts/coccicheck |   27 ++++++++++++++++++++++++++-
>  1 files changed, 26 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index 1bb1a1b..c2a04c2 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -97,10 +97,35 @@ coccinelle () {
>
>  }
>
> +parallel_cleanup () {
> +       pkill -s 0 > /dev/null
> +       rm /tmp/cocci_parallel_$$_* 2>/dev/null
> +       exit
> +}
> +
> +trap parallel_cleanup SIGINT
> +PARALLEL_ID=0
> +
>  if [ "$COCCI" = "" ] ; then
>     for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> -       coccinelle $f
> +       if [ "$PARALLEL" -eq "$PARALLEL" 2>/dev/null ] ; then
> +               if [ "$ONLINE" = "0" ] ; then
> +                       echo Processing: `basename $f`
> +               fi
> +               coccinelle $f>/tmp/cocci_parallel_$$_$PARALLEL_ID 2>&1 &
> +               PARALLEL_ID=$(($PARALLEL_ID + 1))
> +               while [ "`jobs -p | wc -l`" -ge "$PARALLEL" ] ; do
> +                       sleep 3
> +               done
> +       else
> +               coccinelle $f
> +       fi
>     done
> +    wait
> +    if [ "$PARALLEL_ID" -ge "0" ] ; then
> +       cat /tmp/cocci_parallel_$$_*
> +       parallel_cleanup
> +    fi
>  else
>     coccinelle $COCCI
>  fi
> --
> 1.7.2.5
>
>



-- 
Nicolas Palix
http://sardes.inrialpes.fr/~npalix/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/