linux-kernel - Re: [PATCH 13/13] memblock, x86: Replace memblock_x86_reserve/free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 Jul 2011 10:07:56 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	mingo@...hat.com, hpa@...or.com, tglx@...utronix.de,
	benh@...nel.crashing.org, davem@...emloft.net,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	x86@...nel.org
Subject: Re: [PATCH 13/13] memblock, x86: Replace
 memblock_x86_reserve/free_range() with generic ones

Hello, Yinghai.

On Tue, Jul 26, 2011 at 05:59:13PM -0700, Yinghai Lu wrote:
> yes, with bootmem wrap stage, the print out are all the same.
> 
> will have
> __alloc_memory_core_early+0x63
> everywhere.
> 
> add name print out for comparing, name could give some hint.

The better solution would be making __alloc_memory_core_early() pass
in its caller and print it out.  I don't think requiring pretty name
just for debugging is a good or scalable idea.  There's no reason to
bother API users with it.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/