lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Jul 2011 17:35:10 -0700 (PDT) From: Andi Kleen <andi@...stfloor.org> To: imammedo@...hat.com, olaf@...fle.de, ak@...ux.intel.com, konrad.wilk@...cle.com, dtor@...l.ru, linux-kernel@...r.kernel.org, stable@...nel.org, tim.bird@...sony.com, linux-kernel@...r.kernel.org, stable@...r.kernel.org Subject: [PATCH] [18/98] Input: xen-kbdfront - fix mouse getting stuck after save/restore 2.6.35-longterm review patch. If anyone has any objections, please let me know. ------------------ From: Igor Mammedov <imammedo@...hat.com> commit c36b58e8a9112017c2bcc322cc98e71241814303 upstream. Mouse gets "stuck" after restore of PV guest but buttons are in working condition. If driver has been configured for ABS coordinates at start it will get XENKBD_TYPE_POS events and then suddenly after restore it'll start getting XENKBD_TYPE_MOTION events, that will be dropped later and they won't get into user-space. Regression was introduced by hunk 5 and 6 of 5ea5254aa0ad269cfbd2875c973ef25ab5b5e9db ("Input: xen-kbdfront - advertise either absolute or relative coordinates"). Driver on restore should ask xen for request-abs-pointer again if it is available. So restore parts that did it before 5ea5254. Acked-by: Olaf Hering <olaf@...fle.de> Signed-off-by: Igor Mammedov <imammedo@...hat.com> Signed-off-by: Andi Kleen <ak@...ux.intel.com> [v1: Expanded the commit description] Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> Signed-off-by: Dmitry Torokhov <dtor@...l.ru> --- drivers/input/xen-kbdfront.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) Index: linux-2.6.35.y/drivers/input/xen-kbdfront.c =================================================================== --- linux-2.6.35.y.orig/drivers/input/xen-kbdfront.c +++ linux-2.6.35.y/drivers/input/xen-kbdfront.c @@ -285,7 +285,7 @@ static void xenkbd_backend_changed(struc enum xenbus_state backend_state) { struct xenkbd_info *info = dev_get_drvdata(&dev->dev); - int val; + int ret, val; switch (backend_state) { case XenbusStateInitialising: @@ -296,6 +296,16 @@ static void xenkbd_backend_changed(struc case XenbusStateInitWait: InitWait: + ret = xenbus_scanf(XBT_NIL, info->xbdev->otherend, + "feature-abs-pointer", "%d", &val); + if (ret < 0) + val = 0; + if (val) { + ret = xenbus_printf(XBT_NIL, info->xbdev->nodename, + "request-abs-pointer", "1"); + if (ret) + pr_warning("can't request abs-pointer\n"); + } xenbus_switch_state(dev, XenbusStateConnected); break; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists