linux-kernel - Re: [PATCH v4 2/3] mmc: core: add random fault injection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 Jul 2011 21:46:21 +0200
From:	Per Forlin <per.forlin@...aro.org>
To:	Akinobu Mita <akinobu.mita@...il.com>
Cc:	linaro-dev@...ts.linaro.org,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org, linux-doc@...r.kernel.org,
	Venkatraman S <svenkatr@...com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Arnd Bergmann <arnd@...db.de>,
	Sourav Poddar <sourav.poddar@...com>,
	Chris Ball <cjb@...top.org>,
	J Freyensee <james_p_freyensee@...ux.intel.com>,
	Randy Dunlap <rdunlap@...otime.net>
Subject: Re: [PATCH v4 2/3] mmc: core: add random fault injection

On 27 July 2011 18:08, Akinobu Mita <akinobu.mita@...il.com> wrote:
> 2011/7/27 Per Forlin <per.forlin@...aro.org>:
>
>> There is an issue with patch v4 now when fault_attr is per-host.
>> Without your patch the entry is still created at the root but there
>> are many instances of fault-attr. I think it's better to wait for your
>> patch to make it into the mmc-next tree before submitting my patch. I
>> will prepare a patch v5 that depends on your upcoming changes in
>> fault-inject with a note that states the dependency.
>
> Or you can prepare a patch for -mm and ask Andrew to add it to the -mm
> tree.
>
Thanks for the tip,

>> Would you mind adding "patch 1/3" (export_symbol_gpl) to your
>> patch-set since it depends on the new function names in your patch?
>> If not, I can resend the patch on top of your changes to match the new
>> function names if you prefer to have this patch separate.
>
> I recommend it to be a part of your patchset.  The new function name
> (fault_create_debugfs_attr) is not likely to change for a time.  You can
> add Acked-by: Akinobu Mita <akinobu.mita@...il.com>
>
Beside fault_create_debugfs_attr() the other function is should_fail.
I presume this name will be changed too, and start with the fault_?

Regards,
Per
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/