linux-kernel - power_supply: USB charging question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 28 Jul 2011 15:38:42 +0300
From:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:	Anton Vorontsov <cbouatmailru@...il.com>,
	David Woodhouse <dwmw2@...radead.org>
Cc:	linux-kernel@...r.kernel.org
Subject: power_supply: USB charging question

Hi,

I'm looking for a way to create generic USB charging support. I want
to take advantage of the power supply class, but there is one problem.
How do I get properties from the external power supply?

The batteries need to get the CURRENT_MAX property from USB chargers.
It's not enough to be aware are they supplied or not. We must obey the
bMaxPower field from the USB configuration that the USB host has
selected when charging from normal downstream port.

There are several ways that I thought could solve this. Firstly,
simply deliver the external power_supply with the
external_power_changed hook and leave the problem to the drivers. This
did not feel like an ideal solution.

Next idea. Add functions for getting properties from the supplying
power supply:

static int power_supply_find_supplier(struct device *dev, void
data)
{
       struct power_supply *psy = (struct power_supply *)data;
       struct power_supply *epsy = dev_get_drvdata(dev);
       int i;

       for (i = 0; i < epsy->num_supplicants; i++)
               if (!strcmp(epsy->supplied_to[i], psy->name))
                       return 1;

       return 0;
}

int power_supply_get_supplier_property(struct power_supply *psy,
                                       enum power_supply_property psp,
                                       union power_supply_propval *val);
{
       struct power_supply *epsy;
       struct device *dev;

       dev = class_find_device(power_supply_class, NULL, psy,
                               power_supply_find_supplier);
       if (!dev)
               return 1;

       epsy = dev_get_drvdata(dev);
       put_device(dev);

       return epsy->get_property(epsy, psp, &val);
}
EXPORT_SYMBOL_GPL(power_supply_get_supplier_property);

Third idea. We only need to know how much are we allowed to draw, so
add a function for that purpose only. Something like
"power_supply_how_much_can_i_draw". Same as power_supply_am_i_supplied()
except the property would be POWER_SUPPLY_PROP_CURRENT_MAX.

How do you think this should be handled? What would be the best
solution?

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/