linux-kernel - Re: [PATCH -next] target: iscsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 28 Jul 2011 13:10:13 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	scsi <linux-scsi@...r.kernel.org>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, target-devel@...r.kernel.org
Subject: Re: [PATCH -next] target: iscsi_target depends on NET

On Thu, 2011-07-28 at 09:48 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...otime.net>
> 
> iscsi target code uses lots on network interface functions, so it
> should depend on NET.  Fixes many build errors when NET is not enabled:
> 
> ERROR: "kernel_sendmsg" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "in_aton" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "sock_release" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "kernel_listen" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "kernel_setsockopt" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "kernel_recvmsg" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "kernel_accept" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "sock_create" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "kernel_bind" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> ERROR: "in6_pton" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
> ---
>  drivers/target/iscsi/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20110728.orig/drivers/target/iscsi/Kconfig
> +++ linux-next-20110728/drivers/target/iscsi/Kconfig
> @@ -1,5 +1,6 @@
>  config ISCSI_TARGET
>  	tristate "Linux-iSCSI.org iSCSI Target Mode Stack"
> +	depends on NET
>  	select CRYPTO
>  	select CRYPTO_CRC32C
>  	select CRYPTO_CRC32C_INTEL if X86

Committed as d52a10d00 and pushed into target-pending.git/for-next.

Thanks Randy!

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/