linux-kernel - [PATCH] Fix a argument WARN bug of scripts/checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Jul 2011 15:14:12 +0800
From:	gmail <teawater@...il.com>
To:	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: [PATCH] Fix a argument WARN bug of scripts/checkpatch.pl

Sorry the prev patch have the format error.  So I re-send it.

Get following error with a patch that have min_t error:
Use of uninitialized value in concatenation (.) or string at
scripts/checkpatch.pl line 1256.
WARNING:
This is because:
				}
				WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
			}
It lost the first argument.
So make a patch to fix it.

Signed-off-by: Hui Zhu <teawater@...il.com>
---
 scripts/checkpatch.pl |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2574,7 +2574,8 @@ sub process {
 				} else {
 					$cast = $cast2;
 				}
-				WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
+				WARN("MINMAX",
+				     "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
 			}
 		}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/