linux-kernel - Re: [PATCH 15/18] dmaengine/amba-pl08x: Pass flow controller information with slave channel data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 30 Jul 2011 22:36:48 -0700
From:	viresh kumar <viresh.linux@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Viresh Kumar <viresh.kumar@...com>, vinod.koul@...el.com,
	dan.j.williams@...el.com, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux@....linux.org.uk,
	armando.visconti@...com, shiraz.hashim@...com, vipin.kumar@...com,
	rajeev-dlh.kumar@...com, deepak.sikri@...com,
	vipulkumar.samar@...com, amit.virdi@...com, pratyush.anand@...com,
	bhupesh.sharma@...com
Subject: Re: [PATCH 15/18] dmaengine/amba-pl08x: Pass flow controller
 information with slave channel data

On 7/30/11, Linus Walleij <linus.walleij@...aro.org> wrote:
> 2011/7/29 Viresh Kumar <viresh.kumar@...com>:
>
> I have the same comment as Russell basically:
>
>> @@ -65,6 +69,7 @@ struct pl08x_channel_data {
>>        int max_signal;
>>        u32 muxval;
>>        u32 cctl;
>> +       u32 fc;
>
> bool device_fc;
>
> or similar. Then encode the necessary bits if the device controls
> flow, and fall back to default (DMAC control) otherwise.
>

Yes. I thought of exactly the same code.

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/