linux-kernel - Re: [PATCH V2 6/9] efivars: String functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 2 Aug 2011 09:48:28 -0700
From:	Tony Luck <tony.luck@...el.com>
To:	Matthew Garrett <mjg@...hat.com>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org, mikew@...gle.com
Subject: Re: [PATCH V2 6/9] efivars: String functions

On Thu, Jul 21, 2011 at 1:57 PM, Matthew Garrett <mjg@...hat.com> wrote:
> +static unsigned long
> +utf16_strlen(efi_char16_t *s)
> +{
> +       return utf16_strnlen(s, ~0UL);
> +}
> +

When building with CONFIG_PSTORE=n, I see a warning:

drivers/firmware/efivars.c:161: warning: ‘utf16_strlen’ defined but not used

I can just slap:

#ifdef CONFIG_PSTORE
...
#endif

around this function definition - but I wondered if there was a better way
to fix it?

-Tony

Also with CONFIG_PSTORE=n I see:
drivers/firmware/efivars.c:602: warning: initialization from
incompatible pointer type
but that one just needs the stub definition of "efi_pstore_write" to
match the real
definition with "part" being unsigned.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/