linux-kernel - Re: [PATCH] shm: fix a race between shm_exit() and shm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Aug 2011 15:45:00 +0200
From:	Richard Weinberger <richard@....at>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Thadeu Lima de Souza Cascardo <cascardo@...aslivre.org>,
	linux-kernel@...r.kernel.org, marc.zyngier@....com,
	manuel.lauss@...glemail.com, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, segoon@...nwall.com, gregkh@...e.de
Subject: Re: [PATCH] shm: fix a race between shm_exit() and shm_init()

On Mittwoch 03 August 2011 15:33:27 Kay Sievers wrote:
> On Wed, Aug 3, 2011 at 15:13, Thadeu Lima de Souza Cascardo
> 
> <cascardo@...aslivre.org> wrote:
> > As Marc Zyngier has pointed out, the culprit is driver_init, which
> > calls devices_init. I'd say other calls from driver_init also call into
> > kset and kobject, which will dispatch uevent helper.
> > 
> > I tried to reproduce the problem using UML and only was successful after
> > setting CONFIG_UEVENT_HELPER_PATH. I guess we could obsolete this
> > feature and plan its removal soon. Is anybody still using this?
> 
> Forking binaries from the kernel for frequent events is something
> fundamentally wrong to do. It is not even rate-limited or has any
> upper bounds. It is known to create out-of-memory situations on
> machines with many devices and tiny RAM. Configs that virtualizations
> with many guests use pretty often. They can not even bootup with
> /sbin/hotplug enabled then.
> 
> It would be nice to remove that broken thing, no common system or
> distro uses it since quite some years now. But I wouldn't be surprised
> if some people still use it for whatever hack they need locally.
> 

True.

I'll remove CONFIG_UEVENT_HELPER_PATH from UML's defconfig.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/