linux-kernel - Re: [PATCH] nbd: nbd sysfs framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Aug 2011 16:34:26 -0700
From:	Greg KH <greg@...ah.com>
To:	Paul Clements <paul.clements@...sios.com>
Cc:	andrew morton <akpm@...ux-foundation.org>,
	kernel list <linux-kernel@...r.kernel.org>,
	nbd-general@...ts.sourceforge.net
Subject: Re: [PATCH] nbd: nbd sysfs framework

On Wed, Aug 03, 2011 at 07:15:51PM -0400, Paul Clements wrote:
> Description: The patch creates a new sysfs entry framework for nbd.

Why?  What does this buy us except an increase in code size for no added
benifit?  You seem to be stripping out the driver layer here and using
"raw" kobjects, why?  That's generally never a good idea (hint, I think
you just caused a race and userspace bug with your change as well
because of this...)

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/