lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Aug 2011 08:58:21 +0100 From: Ben Dooks <ben@...nity.fluff.org> To: Stephen Warren <swarren@...dia.com> Cc: Thomas Gleixner <tglx@...utronix.de>, Mark Brown <broonie@...nsource.wolfsonmicro.com>, Liam Girdwood <lrg@...com>, Chris Ball <cjb@...top.org>, ccross@...roid.com, olof@...om.net, alsa-devel@...a-project.org, linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it On Thu, Aug 04, 2011 at 05:00:18PM -0600, Stephen Warren wrote: > Many IRQs are associated with GPIO pins. When the pin is used as an IRQ, > it can't be used as anything else; it should be requested. Enhance the > core interrupt code to call gpio_request() and gpio_direction_input() for > any IRQ that is also a GPIO. This prevents duplication of these calls in > each driver that uses an IRQ. > > Signed-off-by: Stephen Warren <swarren@...dia.com> > --- > kernel/irq/manage.c | 23 +++++++++++++++++++++-- > 1 files changed, 21 insertions(+), 2 deletions(-) > > diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c > index 0a7840a..6e2db72 100644 > --- a/kernel/irq/manage.c > +++ b/kernel/irq/manage.c > @@ -7,6 +7,7 @@ > * This file contains driver APIs to the irq subsystem. > */ > > +#include <linux/gpio.h> > #include <linux/irq.h> > #include <linux/kthread.h> > #include <linux/module.h> > @@ -875,7 +876,7 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) > struct irqaction *old, **old_ptr; > const char *old_name = NULL; > unsigned long flags, thread_mask = 0; > - int ret, nested, shared = 0; > + int ret, nested, shared = 0, gpio = -1; > cpumask_var_t mask; > > if (!desc) > @@ -978,6 +979,16 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) > old = *old_ptr; > } while (old); > shared = 1; > + } else { > + gpio = irq_to_gpio(irq); > + if (gpio_is_valid(gpio)) { > + ret = gpio_request(gpio, new->name); > + if (ret < 0) > + goto out_mask; > + ret = gpio_direction_input(gpio); > + if (ret < 0) > + goto out_mask; > + } First,y gpio_direction_input() is an action specific to the implementation and would break on the s3c24xx series as the irq mode is also part of the gpio i/o/sfn configuration Secondly, you are going to have to go through all the soc code and fixup the missing or bad implmenetations of irq_to_gpio() as a number of SoCs are not implemented or worse are so badly implemented you will get valid results for non-gpio interrupts. > } > > /* > @@ -1083,6 +1094,8 @@ mismatch: > ret = -EBUSY; > > out_mask: > + if (gpio_is_valid(gpio)) > + gpio_free(gpio); > raw_spin_unlock_irqrestore(&desc->lock, flags); > free_cpumask_var(mask); > > @@ -1127,6 +1140,7 @@ static struct irqaction *__free_irq(unsigned int irq, void *dev_id) > struct irq_desc *desc = irq_to_desc(irq); > struct irqaction *action, **action_ptr; > unsigned long flags; > + int gpio; > > WARN(in_interrupt(), "Trying to free IRQ %d from IRQ context!\n", irq); > > @@ -1165,8 +1179,13 @@ static struct irqaction *__free_irq(unsigned int irq, void *dev_id) > #endif > > /* If this was the last handler, shut down the IRQ line: */ > - if (!desc->action) > + if (!desc->action) { > irq_shutdown(desc); > + /* If the IRQ line is a GPIO, it's no longer in use */ > + gpio = irq_to_gpio(irq); > + if (gpio_is_valid(gpio)) > + gpio_free(gpio); > + } > > #ifdef CONFIG_SMP > /* make sure affinity_hint is cleaned up */ > -- > 1.7.0.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@...ts.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Ben Dooks, ben@...ff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists